perf(zkatdlog): optimize IPA prover using native gnark-crypto arithmetic - #2154

Hi @adecaro and @AkramBitar ,

I have updated the PR branch (perf/zkp-ipa-optimization) to resolve the CI build and check failures:

1. Fixed Module Import Paths: Updated imports in token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof/ from legacy github.com/hyperledger-labs/fabric-token-sdk to github.com/LFDT-Panurus/panurus matching go.mod.
2. Code Formatting: Applied gofmt -s -w across all modified files in bulletproof to resolve the make checks formatting failure.
3. Verification:
   • All unit tests in token/core/zkatdlog/nogh/v1/crypto/rp/bulletproof pass locally (go test ./... PASS).
   • cgo-check builds (tokengen, artifactgen) compile with CGO_ENABLED=0.
   • DCO sign-off is included in the commit.

Could you please trigger/re-run the CI workflows and let me know if any further changes are needed? Thanks!

@SurbhiAgarwal1

Thanks a lot for submitting this PR!
I also want to apologize in advance if it takes me some time to review it. I'll get to it as soon as possible.

Regards,
Akram

@neetance

Could you please help to review this PR?

Thanks a lot,
Akram

Thanks for this, @SurbhiAgarwal1, the native-arithmetic port of the inner-product/MSM prep looks good and follows the existing GnarkFr[T] pattern correctly.
Can you also share the benchmark numbers for before and after the changes so that we can make the complete comparison and see the overall effects of this pr.
Thanks 🙏

Thanks for this, @SurbhiAgarwal1, the native-arithmetic port of the inner-product/MSM prep looks good and follows the existing GnarkFr[T] pattern correctly. Can you also share the benchmark numbers for before and after the changes so that we can make the complete comparison and see the overall effects of this pr. Thanks 🙏

@neetance

Thanks a lot for your support.

Regards,
Akram

Hi @neetance and @AkramBitar,

Here are the benchmark numbers for the native gnark-crypto arithmetic path:

• BN254 Native IPA Prover: 13.70 ms/op (803,996 B/op, 8,010 allocs/op)
• BLS12-381 Native IPA Prover: 22.99 ms/op (775,943 B/op, 6,659 allocs/op)
• Standard IPA Prover Baseline: 20.48 ms/op (772,089 B/op, 6,638 allocs/op)
• End-to-End Bulletproof Prover: 44.35 ms/op (1,097,854 B/op, 10,220 allocs/op)

Please see the attached terminal benchmark output below for complete details. Thanks!

Hi @SurbhiAgarwal1,

Thanks a lot for running the benchmarks! I assume these are the results after the fix. It would be great if we could also have the benchmark numbers from before and after the changes, so we can make a complete comparison and see the overall impact of this PR, as @neetance mentioned above.

Thanks a million,
Akram

Hello @SurbhiAgarwal1

Any update on that PR?

Regards,
Akram

Hi @AkramBitar, apologies for the delay. I’ve been busy with some other work and haven’t been able to get back to this yet. I’ll work on the before-and-after benchmark comparison and update the PR within the next 2–3 days. Thanks for your patience!

@SurbhiAgarwal1
Thanks a lot for the update